ref(store): Validate database_name before CREATE DATABASE#721
Merged
Conversation
`CREATE DATABASE` cannot use bind parameters for the database name, so the name is interpolated into the statement. Restrict it to a safe identifier charset (ASCII alphanumerics and underscores) to rule out SQL injection. ref STREAM-1125 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
markstory
approved these changes
Jun 19, 2026
evanh
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE DATABASEcannot use bind parameters for the database name, so the name has to be interpolated directly into the statement. This restricts it to a safe identifier charset (ASCII alphanumerics and underscores) before interpolation, ruling out SQL injection viadatabase_name.This PR mainly exists to pacify security scanners, not because this is a real issue.
ref STREAM-1125
🤖 Generated with Claude Code